[PATCH] D114859: [clang-format] Add better support for co-routinues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b95aed2a04: [clang-format] Add better support for co-routinues (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D114859: [clang-format] Add better support for co-routinues

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22727 + +TEST_F(FormatTest, CoRoutineawait) { + verifyFormat("int x = co_await foo();"); MyDeveloperDay wrote: > Quuxplusone wrote: > > > naming of the tests is to allow easy r

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22727 + +TEST_F(FormatTest, CoRoutineawait) { + verifyFormat("int x = co_await foo();"); Quuxplusone wrote: > naming of the tests is to allow easy running of all CoRoutine t

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay updated this revision to Diff 391054. MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 Files: clang/docs/ReleaseNotes.rst

[PATCH] D114859: [clang-format] Add better support for co-routinues

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM % comments. I agree with all the formatting decisions shown in the new tests. Comment at: clang/docs/ReleaseNotes.rst:270 +- Improved Coroutinues support. +

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22748-22749 +TEST_F(FormatTest, CoRoutinereturn) { + verifyFormat("int x = co_return foo();"); + verifyFormat("int x = (co_return foo());"); + verifyFormat("co_return (42);"); M

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22748-22749 +TEST_F(FormatTest, CoRoutinereturn) { + verifyFormat("int x = co_return foo();"); + verifyFormat("int x = (co_return foo());"); + verifyFormat("co_return (42);"); -

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay updated this revision to Diff 390980. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 Files: clang/docs/ReleaseNotes.rst clang/l

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22735 + verifyFormat("co_await a; // comment"); + verifyFormat("void test0() { co_await a; }"); +} It may be worth to add following tests: ``` co_await co_await co_await foo(); c

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, Quuxplusone, ChuanqiXu, EricWF. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Responding to a Discord call to help D113977: [Coroutine] Warn