[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef); My

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Its really this case that caused me issues, the behaviour for the foo {} cases was different from the ::operator cases. My feeling is that one is being detected as a function the other not. verifyFormat("::operat

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = []

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef); cr

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay updated this revision to Diff 390445. MyDeveloperDay added a comment. Remove unrelated file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114725/new/ https://reviews.llvm.org/D114725 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTes

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay updated this revision to Diff 390443. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh,

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14125 verifyFormat("typedef void (*cb) (int);", Space); // FIXME these tests regressed behaviour. + verifyFormat("T A::operator() ();", Space); Remove the comment too.

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay updated this revision to Diff 390407. MyDeveloperDay added a comment. bring back another 2 verifyFormats CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114725/new/ https://reviews.llvm.org/D114725 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/For

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: crayroud. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. bring back the valid tests removed as part of D114696: [clang-format] regressed default behavior for operator pare