MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:14277
+ // FIXME these tests regressed behaviour.
// verifyFormat("T A::operator() () {}", SpaceFuncDef);
verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef);
----------------
crayroud wrote:
> crayroud wrote:
> > What do you think of enabling this test and to remove the space before the
> > opening parenthesis ? As it is now the expected behaviour to have no space.
> In https://reviews.llvm.org/D114696, you proposed to add an operator
> overloading option to SpaceBeforeParensOptions. This example: "T
> A::operator() () {}" should be configured from AfterFunctionDefinitionName or
> operator overloading ?
in this circumstance can you explain why you want to treat differently? I can't
tell what you intended here was it by design or as a consequence?
```
verifyFormat("T A::operator()();", SpaceFuncDef);
verifyFormat("T A::operator() () {}", SpaceFuncDef);
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114725/new/
https://reviews.llvm.org/D114725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
