This revision was automatically updated to reflect the committed changes.
Closed by commit rG9699c0fea355: [clang-tidy][NFC] Simplify ClangTidyStats
(authored by carlosgalvezp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113847/new/
https://revie
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:61-64
- unsigned errorsIgnored() const {
+ int errorsIgnored() const {
retur
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:61-64
- unsigned errorsIgnored() const {
+ int errorsIgnored() const {
return ErrorsIgnoredNOLINT + ErrorsIgnoredCheckFilter +
ErrorsIgnoredNonUserCode +
carlosgalvezp updated this revision to Diff 387290.
carlosgalvezp added a comment.
Fix refactoring bug.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113847/new/
https://reviews.llvm.org/D113847
Files:
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
Index: clang-tools-ex
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Err
carlosgalvezp updated this revision to Diff 387231.
carlosgalvezp edited the summary of this revision.
carlosgalvezp added a comment.
- Use = initialization.
- Revert to unsigned.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113847/new/
https://reviews.llvm.org/D113847
Files:
clang-
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Err
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Err
aaron.ballman added a comment.
Btw, I'm in WG14 (C) standards meetings all week this week and on vacation next
week, so my availability for code reviews is pretty limited for the next while.
So despite my comments here, if you don't get a response back from me in a
timely manner, don't hold up
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Err
whisperity added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Errors
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), Err
salman-javed-nz added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
-ErrorsIgnoredNonUserCode(0), E
carlosgalvezp created this revision.
carlosgalvezp added reviewers: aaron.ballman, whisperity.
Herald added subscribers: rnkovacs, xazax.hun.
carlosgalvezp requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
- Use NSDMI and remove c
14 matches
Mail list logo
