carlosgalvezp created this revision.
carlosgalvezp added reviewers: aaron.ballman, whisperity.
Herald added subscribers: rnkovacs, xazax.hun.
carlosgalvezp requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
- Use NSDMI and remove constructor.
- Replace "unsigned" with "int". Unsigned ints should not be used to express
that "a number cannot be negative". To count things and perform arithmetic, we
should use regular ints. Unsigned ints are useful for e.g. bitwise operations.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D113847
Files:
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
===================================================================
--- clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
+++ clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
@@ -45,20 +45,15 @@
std::vector<std::string> EnabledDiagnosticAliases;
};
-/// Contains displayed and ignored diagnostic counters for a ClangTidy
-/// run.
+/// Contains displayed and ignored diagnostic counters for a ClangTidy run.
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0),
ErrorsIgnoredNOLINT(0),
- ErrorsIgnoredNonUserCode(0), ErrorsIgnoredLineFilter(0) {}
+ int ErrorsDisplayed{0};
+ int ErrorsIgnoredCheckFilter{0};
+ int ErrorsIgnoredNOLINT{0};
+ int ErrorsIgnoredNonUserCode{0};
+ int ErrorsIgnoredLineFilter{0};
- unsigned ErrorsDisplayed;
- unsigned ErrorsIgnoredCheckFilter;
- unsigned ErrorsIgnoredNOLINT;
- unsigned ErrorsIgnoredNonUserCode;
- unsigned ErrorsIgnoredLineFilter;
-
- unsigned errorsIgnored() const {
+ int errorsIgnored() const {
return ErrorsIgnoredNOLINT + ErrorsIgnoredCheckFilter +
ErrorsIgnoredNonUserCode + ErrorsIgnoredLineFilter;
}
Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
===================================================================
--- clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
+++ clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
@@ -45,20 +45,15 @@
std::vector<std::string> EnabledDiagnosticAliases;
};
-/// Contains displayed and ignored diagnostic counters for a ClangTidy
-/// run.
+/// Contains displayed and ignored diagnostic counters for a ClangTidy run.
struct ClangTidyStats {
- ClangTidyStats()
- : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0),
- ErrorsIgnoredNonUserCode(0), ErrorsIgnoredLineFilter(0) {}
+ int ErrorsDisplayed{0};
+ int ErrorsIgnoredCheckFilter{0};
+ int ErrorsIgnoredNOLINT{0};
+ int ErrorsIgnoredNonUserCode{0};
+ int ErrorsIgnoredLineFilter{0};
- unsigned ErrorsDisplayed;
- unsigned ErrorsIgnoredCheckFilter;
- unsigned ErrorsIgnoredNOLINT;
- unsigned ErrorsIgnoredNonUserCode;
- unsigned ErrorsIgnoredLineFilter;
-
- unsigned errorsIgnored() const {
+ int errorsIgnored() const {
return ErrorsIgnoredNOLINT + ErrorsIgnoredCheckFilter +
ErrorsIgnoredNonUserCode + ErrorsIgnoredLineFilter;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
