EricWF updated this revision to Diff 33236.
EricWF added a comment.
Remove unused "CompileString" functions. The reason they can't be used to
implement `addWarningFlagIfSupported` is because we have to fuss with the flags
before invoking the compiler .
http://reviews.llvm.org/D11333
Files:
jroelofs added inline comments.
Comment at: test/libcxx/compiler.py:195
@@ +194,3 @@
+cmd.remove('-v')
+out, err, rc = lit.util.executeCommand(cmd, input='#error\n')
+assert rc != 0
... you could at least use `compileString` here.
htt
jroelofs added a comment.
I'd say put them in when you have actual uses for them
http://reviews.llvm.org/D11333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Those methods are currently unused but are you opposed to me adding them in
this patch? They will be useful for compiling short tests to check for compiler
features.
http://reviews.llvm.org/D11333
___
cfe-commits mailing li
jroelofs added a comment.
the `addWarningFlagIfSupported` part of this patch LGTM.
Comment at: test/libcxx/compiler.py:88
@@ -87,1 +87,3 @@
+def compileString(self, source, out=None, flags=[], env=None, cwd=None):
+cmd = self.compileCmd('-', out, flags)
---
