[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab abandoned this revision. ab added a comment. This went through so many rebases that the incremental diff is not very helpful ;) Let's start over on github: https://github.com/llvm/llvm-project/pull/65996 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llv

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab updated this revision to Diff 556443. ab added a comment. Herald added subscribers: llvm-commits, wangpc, MaskRay. Herald added projects: LLVM, All. Added the relevant bits of the great documentation John wrote in clang/docs/PointerAuthentication.rst. I tried to trim it down to only the gene

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

bruno added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; + }

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

kristof.beyls added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics"

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

bruno added a comment. Thanks for working on upstreaming this @ab. Overall looks good to me, I see clang-format issues, are those legit? One more comment inline. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; + } +

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

kristof.beyls added inline comments. Comment at: clang/lib/Headers/ptrauth.h:19-37 + /* A process-independent key which can be used to sign code pointers. + Signing and authenticating with this key is a no-op in processes + which disable ABI pointer authentication. */ +

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

rjmccall added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; +

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. If you look at the `immintrin.h` header, the access too many builtins is guarded by ifdefs. ` #if defined(__SSSE3__)` The builtin `__builtin_ia32_reduce_smin_d512` is useless on aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

kristof.beyls added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics"

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. The `avxintrin.h` header has more structured documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llvm.org/D112941 ___ cfe-commits mailing li

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab added a comment. In D112941#3105297 , @tschuett wrote: > The original `ptrauth.h` has the same comment style. Would doxygen style be > an improvement? Hmm, what do you have in mind? Markup for the builtin arguments/returns? The need for `__` prefi

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab updated this revision to Diff 384827. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llvm.org/D112941 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab updated this revision to Diff 384825. ab marked 3 inline comments as done. ab added a comment. Simplify `err_ptrauth_disabled` diagnostic, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llvm.org/D112941 Files:

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. The original `ptrauth.h` has the same comment style. Would doxygen style be an improvement? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llvm.org/D112941 _

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

rjmccall added a comment. Mostly LGTM, although I am not the most unbiased reviewer. :) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def err_ptrauth_invalid_k

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added a comment. The plan to push support for ptrauth_sign_constant, and ptrauth_type_discriminator/ptrauth_string_discriminator in a separate patch is good. This current patch is already big. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def err_ptrauth_invalid_key : These two error types are confusing.

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab created this revision. ab added reviewers: rjmccall, ahatanak, bruno, pcc, apazos, kristof.beyls, t.p.northover, pbarrio, chill, danielkiss, psmith. ab added a project: clang. Herald added subscribers: dexonsmith, zzheng, dang, mgorny. ab requested review of this revision. Building on D90868 <