rjmccall added a comment.
Mostly LGTM, although I am not the most unbiased reviewer. :)
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839
+def err_ptrauth_disabled :
+ Error<"pointer authentication is disabled for the current target">;
+def err_ptrauth_invalid_key :
----------------
apazos wrote:
> These two error types are confusing.
> In which situation would err_ptrauth_disabled be printed?
> With this patch, it is only supported with arm64e triple, all other targets
> it is unsupported.
We could probably just have one of these, yes.
================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:847
+ const llvm::APSInt &value) const {
+ return 0 <= value && value <= 3;
+}
----------------
There's an LLVM constants header for this now, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112941/new/
https://reviews.llvm.org/D112941
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
