[PATCH] D112404: [SPIR-V] Add translator tool

2021-11-18 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki added a comment. Thanks for the help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D112404: [SPIR-V] Add translator tool

2021-11-17 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG49682f14bf3f: [SPIR-V] Add translator tool (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://re

[PATCH] D112404: [SPIR-V] Add translator tool

2021-11-16 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki added a comment. Hi @Anastasia and @bader, This patch should be ready to land, I think. Could you please push it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___

[PATCH] D112404: [SPIR-V] Add translator tool

2021-11-15 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki updated this revision to Diff 387499. linjamaki marked an inline comment as done. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files: clang/lib/Driver/CMa

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-28 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki marked an inline comment as done. linjamaki added a comment. Thanks for the review. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation &C, const Tool &T, + const JobAction &JA,

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-28 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki updated this revision to Diff 383001. linjamaki added a comment. Rename SPIRV::Translator's tool names as suggested by bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files: clang/lib/D

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-28 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. This part looks good to me. Just a couple of minor style comments. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation &C,

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-27 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki updated this revision to Diff 382931. linjamaki marked an inline comment as done. linjamaki added a comment. Remove `--spirv-ext` and `--spirv-max-version`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.or

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-27 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-ext">, +HelpText<"Specify c

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-26 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. This direction of creating a common translator tool makes sense to me! Thanks! Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-

[PATCH] D112404: [SPIR-V] Add translator tool

2021-10-24 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki created this revision. Herald added subscribers: ThomasRaoux, dang, mgorny. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a tool for constructing commands for translating LLVM IR to SPIR-V. Used by HIPSPV tool cha