linjamaki marked an inline comment as done. linjamaki added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1534 + HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-ext">, + HelpText<"Specify comma separated list of allowed/disallowed SPIR-V " ---------------- Anastasia wrote: > Is this flag expected to be similar to `-cl-ext`? > > https://clang.llvm.org/docs/OpenCLSupport.html#cmdoption-cl-ext > > It might be good to see how those can align? I imagine for HIP you haven't > used such flags yet? > Is this flag expected to be similar to `-cl-ext`? > > https://clang.llvm.org/docs/OpenCLSupport.html#cmdoption-cl-ext > > It might be good to see how those can align? It is similar to -cl-ext. I thought it would make sense to have --spirv-ext for defining allowed SPIR-V extensions via the clang driver. I did not think that having both the -cl-ext and the --spirv-ext at the same time may conflict and/or contradict so I’ll remove the options here (--spirv-max-version too). Let’s introduce them in D112410 if needed. > I imagine for HIP you haven't used such flags yet? HIPSPV tool chain passes --spirv-max-version and --spirv-ext options to the LLVM-SPIR-V translator for overriding its defaults. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
