This revision was automatically updated to reflect the committed changes.
Closed by commit rL245810: Instantiate function declarations in instantiated
functions. (authored by sepavloff).
Changed prior to commit:
http://reviews.llvm.org/D11194?vs=32597&id=32923#toc
Repository:
rL LLVM
http:/
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of tweaks. Thanks!
Comment at: lib/AST/DeclBase.cpp:276
@@ +275,3 @@
+ return false;
+LDC = LDC->getParent();
+ }
sepavloff updated this revision to Diff 32597.
sepavloff added a comment.
Lambda functions are now treated as local classes.
http://reviews.llvm.org/D11194
Files:
include/clang/AST/DeclBase.h
lib/AST/DeclBase.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/SemaTemplateInstantiateDecl.
On Tue, Aug 18, 2015 at 10:05 AM, Serge Pavlov wrote:
> sepavloff added inline comments.
>
>
> Comment at: lib/AST/DeclBase.cpp:273
> @@ +272,3 @@
> +return true;
> + if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
> +return ClassD->isLocalClass() && !ClassD->isLambda()
sepavloff added inline comments.
Comment at: lib/AST/DeclBase.cpp:273
@@ +272,3 @@
+return true;
+ if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
+return ClassD->isLocalClass() && !ClassD->isLambda();;
rsmith wrote:
> It's not necessary for this change,
rsmith added inline comments.
Comment at: lib/AST/DeclBase.cpp:273
@@ +272,3 @@
+return true;
+ if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
+return ClassD->isLocalClass() && !ClassD->isLambda();;
It's not necessary for this change, but to match its d
sepavloff updated this revision to Diff 32310.
sepavloff added a comment.
Updated method isLexicallyWithinFunctionOrMethod according to Richard's notes.
http://reviews.llvm.org/D11194
Files:
include/clang/AST/DeclBase.h
lib/AST/DeclBase.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/
