[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 9fcca8b470fb92466ec4cada9fbeacc90096116d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

rjmccall accepted this revision. rjmccall added a comment. This seems reasonable. You could also give `ExitFunctionBodyRAII` an explicit `pop()` operation, but either way is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111814/new/ https://

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think the others had enough time on this one, it LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111814/new/ https://reviews.llvm.

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111814/new/ https://reviews.llvm.org/D111814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); erichkeane wrote: > so the only real change here is that `ExitFunctionBodyRAII` ends here, > instead of the end of the function?

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); so the only real change here is that `ExitFunctionBodyRAII` ends here, instead of the end of the function? I guess this SEEMS pre

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. When reaching the end of a function body, we need to ensure that the `ExitFunctionBodyRAII` object is destroyed before