[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14165 + SpaceFuncDecl.SpaceBeforeParens = FormatStyle::SBPO_Custom; + SpaceFuncDecl.SpaceBeforeParensOptions.AfterFunctionDeclarationName = true; + MyDeveloperDay wrote: > are you

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3161-3169 +if (Line.MightBeFunctionDecl && (Left.is(TT_FunctionDeclarationName) || + Right.is(TT_OverloadedOperatorLParen))) { + if (Line.mightBeFunc

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added a comment. I'm looking at a bug (sorry can't log it as we don't seem to have a working bug tracker!) that causes a regression on `operator new(` and `operator delete(` which I believe I've tracked to this change v12 ~foo() { ::operator delete(bar); } ::operator dele

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud closed this revision. crayroud added a comment. git revision: 6facafe7da59eb02e8c1519670b503efda2f4b58 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. In D110833#3111632 , @crayroud wrote: > I do not have commit access, could you please help with the push? > > Here are the commit details: C. Rayroud - rayro...@gmail.com Will push it on tuesday, if no one objects. I a

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push? Here are the commit details: C. Rayroud - rayro...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 _

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. Could you please wait before to push this changes to the main branch, there is one more point I want to verify. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-comm

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push. Here are the commit details: C. Rayroud CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-commits m

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 384679. crayroud added a comment. Fix ordering of SpaceBeforeParensCustom options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. To me this looks good, if the sorting is finalized. :) Do you need someone to push this for you? If yes please state name and email, if not please wait a few days for o

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked an inline comment as done. crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14275 + verifyFormat("A::A() : a (1) {}", SomeSpace2); + verifyFormat("void f() __attribute__ ((asdf));", SomeSpace2); + verifyFormat("*(&a + 1);\n" ---

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 384352. crayroud marked an inline comment as done. crayroud added a comment. Reorder the options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. Looks good, and I really need this to land, to expand it. ;) Comment at: clang/include/clang/Format/Format.h:3369 +/// \endcode +bool AfterForeachMacros; +/// If ``true``, put a space before opening parentheses only if the ---

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 383995. crayroud added a comment. Add a release note into clang/docs/ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNo

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3469 return true; - if (Right.is(TT_OverloadedOperatorLParen)) -return spaceRequiredBeforeParens(Right); - if (Left.is(tok::comma)) + if (Left.is(tok::comma) && !Right.is(TT_OverloadedOper

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3469 return true; - if (Right.is(TT_OverloadedOperatorLParen)) -return spaceRequiredBeforeParens(Right); - if (Left.is(tok::comma)) + if (Left.is(tok::comma) && !Right.is(TT_Overload

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added a comment. This looks pretty good to me. Could you add a release note into docs/ReleaseNote.rst (we have a .clang-format section) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked 10 inline comments as done. crayroud added a comment. I used the following command to verify my changes on multiple files. Thank you for the tip. clang-format -verbose -n -files clang/docs/tools/clang-formatted-files.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked 6 inline comments as done. crayroud added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3708 +SpaceBeforeParens: Custom +SpaceBeforeParensFlags: + AfterFunctionDefinitionName: true MyDeveloperDay wrote: > I'm not

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 383988. crayroud retitled this revision from "[clang-format] Refactor SpaceBeforeParens to add flags" to "[clang-format] Refactor SpaceBeforeParens to add options". crayroud edited the summary of this revision. crayroud added a comment. - SpaceBeforeParensFl