[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

aaronpuchert added a comment. Herald added a subscriber: pcwang-thead. Herald added a project: All. Basically this should be Ok. We set the `LLVM_HOST_TRIPLE` to match the GCC triple on almost all platforms now. But we'll need to patch `isGNUEnvironment` like D110900

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

tstellar added a comment. This patch should depend on D109837 , otherwise clang builds will be broken on SUSE if you don't pass -DLLVM_DEFAULT_TARGET_TRIPLE to cmake when configuring, and I don't think we should require users to pass this option. Repository:

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

aaronpuchert added a comment. The problem here is that triples are not just used to look up the GCC installation, but the individual components have some meaning. Changing the OS vendor from "unknown" to "suse" doesn't worry me, but dropping "-gnu" might lead us to the problems described in D10

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay added a comment. @marxin Can you check this from Suse perspective? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109727/new/ https://reviews.llvm.org/D109727 ___ cfe-commits mailing list cfe-c

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

luismarques added a comment. In D109727#3004125 , @MaskRay wrote: > The code change of D74399 should be > reverted. The test can stay, but I won't think we need too many > riscv64-$distro-linux-gnu tests. Makes sense.

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay added a comment. In D109727#3003498 , @luismarques wrote: > Regarding D74399 , cmake on a fedora RISC-V > host still detects a generic triple: > > -- LLVM host triple: riscv64-unknown-linux-gnu > -- LLVM defa

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

luismarques added a comment. Regarding D74399 , cmake on a fedora RISC-V host still detects a generic triple: -- LLVM host triple: riscv64-unknown-linux-gnu -- LLVM default target triple: riscv64-unknown-linux-gnu as opposed to the `gcc -dumpmachine` triple

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay created this revision. MaskRay added reviewers: asb, schwab, tstellar. Herald added subscribers: StephenFan, dexonsmith, luismarques, steven.zhang, s.egerton, PkmX, simoncook, hiraditya, kristof.beyls. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald ad