aaronpuchert added a comment.

The problem here is that triples are not just used to look up the GCC 
installation, but the individual components have some meaning. Changing the OS 
vendor from "unknown" to "suse" doesn't worry me, but dropping "-gnu" might 
lead us to the problems described in D109837#3034457 
<https://reviews.llvm.org/D109837#3034457>. (I'll have to test that.)

Doesn't mean we can't have this change, but I think we need to add something 
like `if (Vendor == Triple::SUSE) Environment = Triple::GNU;` somewhere. Or 
perhaps it's there and I'm just missing it?

Regarding `gnueabi[hf]`: maybe the problem was that the GCC triple is different 
from the LLVM triple for some historic reason? So if we configure LLVM with 
target `armv7-suse-linux-gnueabihf` it might just not find the GCC 
installation, but if we leave it as is, LLVM will generate incompatible code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109727/new/

https://reviews.llvm.org/D109727

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to