wlei added a comment.
@rnk @rjmccall Thanks for the suggestion! @wenlei Thanks for the helpful
example!
Changed to use ValueHandle(WeakTrackingVH) for this, please see if this looks
good to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D10938
wlei updated this revision to Diff 371455.
wlei added a comment.
change to use ValueHandle for associated data
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109386/new/
https://reviews.llvm.org/D109386
Files:
clang/lib/CodeGen/CodeGenModule.cpp
wenlei added a comment.
Yes, this looks like the kind of stuff VH is designed for. @wlei here's an
example of how VH is used to handle deletion of BFI of basic blocks:
https://reviews.llvm.org/D75341.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
rjmccall added a comment.
I agree with Reid. IRGen should never be holding naked references (across
different invocations as an `ASTConsumer`) to a replaceable entity. There are
some entities that are known not to be replaceable, but in general the
associated data of a global constructor does
rnk added a comment.
This seems like a good use for a ValueHandle, even if it is slightly more code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109386/new/
https://reviews.llvm.org/D109386
___
cfe-com
wlei created this revision.
Herald added subscribers: hoy, wenlei, lxfind.
wlei requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109386
Files:
clang/lib/CodeGen/CodeGenModul
