This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG26bb1b1dab8b: [RISCV] Add the zvl extension according to the
v1.0 spec (authored by eopXD).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
eopXD updated this revision to Diff 400238.
eopXD added a comment.
Rebase to latest main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/Basic/Targets/RISCV.cpp
clang/test/Driver/ris
eopXD updated this revision to Diff 400111.
eopXD added a comment.
Rebase to latest main.
Resolve test case conflicts due to Zvamo removal.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/l
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
___
eopXD added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187
+def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen",
"ExtZvl::Zvl64b",
+ "'Zvl' (Minimum Vector Length) 64",
+ [FeatureStdExtZvl32b
eopXD updated this revision to Diff 400098.
eopXD marked 8 inline comments as done.
eopXD added a comment.
Address comments.
Thanks for reviewing!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:774
+ while (!WorkList.empty()) {
+auto ExtName = WorkList.pop_back_val();
+auto I = llvm::lower_bound(ImpliedExts, ExtName);
Use StringRef instead of auto here.
achieveartificialintelligence added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187
+def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen",
"ExtZvl::Zvl64b",
+ "'Zvl' (Minimum Vector Length) 64",
+
eopXD added a comment.
ping again, thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
eopXD added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:741-751
+{{"zvl1024b"}, {ImpliedExtsZvl1024b}},
+{{"zvl128b"}, {ImpliedExtsZvl128b}},
+{{"zvl16384b"}, {ImpliedExtsZvl16384b}},
+{{"zvl2048b"}, {ImpliedExtsZvl2048b}},
+{{"zvl256b"}, {I
eopXD updated this revision to Diff 396505.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/Basic/Targets/RISCV.cpp
clang/test/Driver/riscv-arch.c
cla
achieveartificialintelligence added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:741-751
+{{"zvl1024b"}, {ImpliedExtsZvl1024b}},
+{{"zvl128b"}, {ImpliedExtsZvl128b}},
+{{"zvl16384b"}, {ImpliedExtsZvl16384b}},
+{{"zvl2048b"}, {ImpliedExtsZvl2048b}
eopXD added a comment.
Ping, thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
eopXD updated this revision to Diff 394739.
eopXD marked 2 inline comments as done.
eopXD added a comment.
Address comments from Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/B
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:739
static constexpr ImpliedExtsEntry ImpliedExts[] = {
-{{"v"}, {ImpliedExtsV}},
-{{"zfh"}, {ImpliedExtsZfh}},
+{"v", {ImpliedExtsV}},
+{"zfh", {ImpliedExtsZfh}},
eopXD updated this revision to Diff 394471.
eopXD added a comment.
Rebase to latest main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/Basic/Targets/RISCV.cpp
clang/test/Driver/ris
eopXD added inline comments.
Comment at: clang/test/Preprocessor/riscv-target-features.c:230
+// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s
+// CHECK-V-MINVLEN: __riscv_v_min_vlen 128
frasercrmck wrote:
> Are we able to test non-default values of `__riscv
eopXD updated this revision to Diff 394454.
eopXD marked 3 inline comments as done.
eopXD added a comment.
Rebase and address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/B
frasercrmck added inline comments.
Comment at: clang/test/Preprocessor/riscv-target-features.c:230
+// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s
+// CHECK-V-MINVLEN: __riscv_v_min_vlen 128
Are we able to test non-default values of `__riscv_v_min_vlen` he
eopXD added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134
"maximum!");
+ assert(RVVVectorBitsMin >= ZvlLen &&
+ "Minimum V extension vector length should be at least the length "
eopXD wrote:
> eopXD wrote:
> > craig
eopXD updated this revision to Diff 394119.
eopXD marked 8 inline comments as done.
eopXD added a comment.
Rebase and address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Files:
clang/lib/Ba
eopXD added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782
+if (IsZvlExt) {
+ ExtName.consume_back("b");
+ unsigned ZvlLen;
craig.topper wrote:
> craig.topper wrote:
> > I think we should check the return value from consume_back
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782
+if (IsZvlExt) {
+ ExtName.consume_back("b");
+ unsigned ZvlLen;
craig.topper wrote:
> I think we should check the return value from consume_back and getAsInteger
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:714
void RISCVISAInfo::updateImplication() {
+ const StringMap> Implications = {
+ {"v", {"zvlsseg", "zvl128b"}},
I think I'd like to see this as a static data structure rath
eopXD updated this revision to Diff 393185.
eopXD added a comment.
Rebase now since the preceeding patches are accepted.
This patch is ready for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
Fil
25 matches
Mail list logo
