eopXD added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187
+def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen",
"ExtZvl::Zvl64b",
+ "'Zvl' (Minimum Vector Length) 64",
+ [FeatureStdExtZvl32b]>;
+def FeatureStdExtZvl128b : SubtargetFeature<"experimental-zvl128b", "ZvlLen",
"ExtZvl::Zvl128b",
+ "'Zvl' (Minimum Vector Length) 128",
+ [FeatureStdExtZvl64b]>;
+def FeatureStdExtZvl256b : SubtargetFeature<"experimental-zvl256b", "ZvlLen",
"ExtZvl::Zvl256b",
----------------
achieveartificialintelligence wrote:
> I think we can write in this way:
> ```
> foreach i = { 5-15 } in {
> defvar I = !shl(2, i);
> def FeatureStdExtZvl#I#b
> : SubtargetFeature<"experimental-zvl"#I#"b", "ZvlLen",
> "ExtZvl::Zvl"#I#"b",
> "'Zvl' (Minimum Vector Length) "#I,
> [!cast<SubtargetFeature>("FeatureStdExtZvl"#!srl(I,
> 1)#"b")]>;
> }
> ```
Thank you for the tip! I previously don't know TableGen can compute values like
bit-shift left and do value type casting.
Adapted your code snippet. I modified a bit because `Zvl32b` don't imply
anything.
================
Comment at: llvm/lib/Target/RISCV/RISCV.td:188
+ [FeatureStdExtZvl32768b]>;
+def HasStdExtZvl : Predicate<"Subtarget->hasStdExtZvl()">;
+
----------------
craig.topper wrote:
> Is this used?
No it is not, deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108694/new/
https://reviews.llvm.org/D108694
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
