This revision was automatically updated to reflect the committed changes.
Closed by commit rGb2e77cd095a6: gn build: Build libclang.so and libLTO.so on
ELF platforms. (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D108223?vs=366966&id=367318#toc
Repository:
rG LLVM Gith
thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn:19
"//llvm/lib/Target:TargetsToBuild",
+":exports",
]
Run `gn format` before comi
pcc added inline comments.
Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16
- # For now, make libclang a static lib there.
- libclang_target_type = "static_library"
-} else {
thakis wrote:
> probably should update these too:
>
> ```
> % rg
pcc updated this revision to Diff 366966.
pcc added a comment.
Herald added subscribers: ormris, steven_wu, hiraditya.
Also libLTO.so
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108223/new/
https://reviews.llvm.org/D108223
Files:
llvm/utils/gn
thakis added a comment.
Hm, I kind of like the PIC-less build. But probably not worth having a toggle
for it, I suppose. So lg, but:
Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16
- # For now, make libclang a static lib there.
- libclang_target_type = "
pcc created this revision.
pcc added a reviewer: thakis.
pcc requested review of this revision.
Herald added a project: LLVM.
This requires changing the ELF build to enable -fPIC, consistent
with other platforms.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D108223
Files:
l
