pcc added inline comments.
================
Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16
- # For now, make libclang a static lib there.
- libclang_target_type = "static_library"
-} else {
----------------
thakis wrote:
> probably should update these too:
>
> ```
> % rg -F 'rget_type = "static_librar' llvm/utils/gn
> llvm/utils/gn/secondary/compiler-rt/lib/tsan/BUILD.gn
> 12: tsan_target_type = "static_library"
>
> llvm/utils/gn/secondary/compiler-rt/lib/asan/BUILD.gn
> 12: asan_target_type = "static_library"
>
> llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn
> 16: libclang_target_type = "static_library"
>
> llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
> 8: lto_target_type = "static_library"
> ```
Done for llvm/tools/lto.
For the sanitizers the shared-ness of the runtime is tied to what works best on
that platform, rather than whether it's PIC by default (note that all
compiler-rt code is built with -fPIC), so I left them as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108223/new/
https://reviews.llvm.org/D108223
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
