[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG509854b69cea: [clang] Replace asm with __asm__ in cuda header (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield updated this revision to Diff 364277. JonChesterfield added a comment. - consistent __volatile__ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107492/new/ https://reviews.llvm.org/D107492 Files: clang/lib/Headers/__clang_cuda_dev

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield added a comment. In D107492#2926910 , @tra wrote: > In D107492#2926871 , > @JonChesterfield wrote: > >> Therefore I'd like to leave it as `__asm__ volatile`. > > Being the one who introduced incon

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

tra added a comment. In D107492#2926871 , @JonChesterfield wrote: > Therefore I'd like to leave it as `__asm__ volatile`. Being the one who introduced inconsistent use of `__volatile__` and `volatile` in this header, I'm pretty sure that PTX's notion o

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

emankov added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1043 } -#else // CUDA_VERSION >= 9020 +#else // CUDA_VERSION >= 9020 // CUDA no longer provides inline assembly (or bitcode) implementation of these JonChesterfield wr

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1043 } -#else // CUDA_VERSION >= 9020 +#else // CUDA_VERSION >= 9020 // CUDA no longer provides inline assembly (or bitcode) implementation of these JonChester

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield updated this revision to Diff 364274. JonChesterfield added a comment. - whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107492/new/ https://reviews.llvm.org/D107492 Files: clang/lib/Headers/__clang_cuda_device_fu

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield added a comment. Re: `__volatile__`. I've done some background reading on it but can't find the original motivation. `__asm__` exists because the asm word is in the application namespace and asm is an extension. Volatile has been with us since C89 though, and is also accepted un

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

emankov requested changes to this revision. emankov added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1043 } -#else // CUDA_VERSION >= 9020 +#else // CUDA_VERSION >= 9020 // CUDA no longer provid

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:37 #if defined(__cplusplus) -__DEVICE__ void __brkpt() { asm volatile("brkpt;"); } +__DEVICE__ void

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield added a comment. Implemented by `F=__clang_cuda_device_functions.h ; sed -i 's$asm$__asm__$g' $F && clang-format -i $F` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107492/new/ https://reviews.llvm.org/D107492 ___

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

JonChesterfield created this revision. JonChesterfield added reviewers: tra, emankov, gtbercea, jdoerfert. Herald added a subscriber: yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Asm is a gnu extension fo