This revision was automatically updated to reflect the committed changes.
Closed by commit rGacc58504952f: [OpenCL] Add support of __opencl_c_pipes
feature macro. (authored by azabaznov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107154/new/
htt
azabaznov added a comment.
> We might need to fix the target triple in
> clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl to avoid surprises with testing
> but it has better coverage if we don't though...
Yeah, I am not sure now though. It's awful because testing is not deterministic
as we have di
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
We might need to fix the target triple in
`clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl` to avoid surprises with testing
but it has better coverage if we don't though...
azabaznov updated this revision to Diff 363044.
azabaznov added a comment.
Fix doubling run lines, misprint
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107154/new/
https://reviews.llvm.org/D107154
Files:
clang/include/clang/Basic/LangOptions.d
azabaznov created this revision.
azabaznov added reviewers: Anastasia, svenvh.
Herald added subscribers: ldrumm, dexonsmith, yaxunl.
azabaznov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
'pipe' keyword is introduced in OpenCL C 2.0: so