sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288
};
- for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON},
-CDBFile{&BuildCompileComma
This revision was automatically updated to reflect the committed changes.
Closed by commit rG253b8145dedb: [clangd] Avoid range-loop init-list lifetime
subtleties. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D106654?vs=361165&id=361177#toc
Repository:
rG LLVM G
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288
};
- for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON},
-CDBFile{&BuildCompileCommandsJson, parseJSON},
-
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks! it is unfortunate that history won't remember what an adventure it was
to figure out the issue :D
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
The original code appears to
