sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288
};
- for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON},
- CDBFile{&BuildCompileCommandsJson, parseJSON},
- CDBFile{&CompileFlagsTxt, parseFixed}}) {
+ CDBFile Files[] = {
+ {&CompileCommandsJson, parseJSON},
----------------
kadircet wrote:
> kadircet wrote:
> > nit: I'd make it `static const` just to make sure they are not going away
> > this time + it will save up some stack space.
> >
> > nit: Maybe also get rid of the struct's name ? (`static const struct { ...
> > } Files[] = { ... };`)
> as discussed, `CachedFile` entries are actually pointers to members, so NVM
> the `static`.
There are pointers to members in here! The fact that `static const` even
compiles is a massive footgun :-(
We should write a clang-tidy check for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106654/new/
https://reviews.llvm.org/D106654
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
