[PATCH] D105876: OMPIRBuilder for Interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa24558cfa6: OMPIRBuilder for Interop directive (authored by sriharikrishna, committed by tianshilei1992). Repository: rG LLVM Github Monorepo C

[PATCH] D105876: OMPIRBuilder for Interop directive

tianshilei1992 updated this revision to Diff 403737. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CGStmt

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 372329. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cp

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, please rebase on top of trunk and use ` ConstantInt::get(Int32, 0)` instead of the APInt way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 362070. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cp

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361913. sriharikrishna marked an inline comment as done. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna marked an inline comment as done. sriharikrishna added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331 + if (const auto *C = S.getSingleClause()) { +llvm::Value *InteropvarPtr = +EmitLValue(C->getInteropVar()).getPointer(*this

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331 + if (const auto *C = S.getSingleClause()) { +llvm::Value *InteropvarPtr = +EmitLValue(C->getInteropVar()).getPointer(*this); +llvm::omp::OMPInteropType InteropType = llvm::om

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361186. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361079. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert added a comment. you need to squash your commits locally and update this revision with a single commit/diff. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6323-6327 + if (S.hasClausesOfKind() && + !(S.getSingleClause() || +S.getSingleClause() || +

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358631. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpe

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6348-6352 + } else if(HaveNowaitClause == true) { +assert("Nowait clause is used separately in OMPInteropDirective."); } else { -llvm_unreachable("Missing Interop clauses."); +assert("Un

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358587. sriharikrishna added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6310-6311 + int DependClauseCount = 0; + for (const auto *DC : S.getClausesOfKind()) +DependClauseCount++; + assert(DependClauseCount <= 1 && "Multiple OMPDependClause not supported."); -

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert added a subscriber: mikerice. jdoerfert added a comment. There are 3 clang tidy warnings to address. Overall this is a good first step. @ABataev @mikerice is there any major problem with this? If not we should try to get it in asap and improve it in tree. Comment at

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna created this revision. sriharikrishna added reviewers: jdoerfert, ABataev, RaviNarayanaswamy. Herald added a subscriber: hiraditya. sriharikrishna requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Im