[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaeef1995ab4: [analyzer] Allow cmake options to be passed to satest container (authored by manas, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. Gentle ping! I think landing it will make collecting analyzer information easier (in terms of faster build) as more (appropriate) cmake options can be passed via cmdline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 ___

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356821. manas added a comment. Pass commands through settings instead of rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.p

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:12 settings, rest = parse_arguments() +cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest)) if settings.wait: vsavchenko wrote: > I think we should still use `argparse

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

vsavchenko added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:12 settings, rest = parse_arguments() +cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest)) if settings.wait: I think we should still use `argparse` for stuff lik

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356575. manas edited the summary of this revision. manas added a comment. Edit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/ent

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. In D105447#2858740 , @manas wrote: > Restore global cmake command Apparently, my initial observation of `LLVM_BUILD_RUNTIME=OFF` hogging up memory was false and I also didn't know what was the default value for this option. Hence

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356574. manas added a comment. Restore global cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.py Index: clang/u

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a reviewer: jdoerfert. Herald