[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa454dda2eed: [analyzer] LValueToRValueBitCasts should evaluate to an r-value (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/ne

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

vsavchenko accepted this revision. vsavchenko added a comment. Oh, wow, that's awesome! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal added a comment. In D105017#2848465 , @NoQ wrote: > So it worked out of the box? Great! Yes, it did. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 _

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. So it worked out of the box? Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 ___ cfe-commits m

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue; steakhal

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue; NoQ wrote: > You didn't start it but that's, ugh, n

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal updated this revision to Diff 355245. steakhal marked an inline comment as done. steakhal added a comment. Evaluate `LValueToRValueBitCast`s the same way as we evaluate `LValueToRValue` casts. Extended the tests accordingly. Thanks for the hint @NoQ! It looks much better now. CHANGES

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

NoQ added a comment. Thanks, nice! More stuff to support. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:307 if (CastE->getCastKind() == CK_LValueToRValue) { for (ExplodedNodeSet::iterator I = dstPreStmt.begin(), E = dstPreStmt.end(); How

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. He