[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a96e906cc0: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes (authored by sbc100). Changed prior to commit: https://reviews.llv

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I believe we have all agreed that this is the right path forward, and so this can land? Doing this change now in emscripten does not prevent us from changing the emscripten ABI again later,

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. In D104808#2836991 , @kripken wrote: > In D104808#2836942 , @sunfish wrote: > >> Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or >> wasm32-wasi eventually? This

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken added a comment. In D104808#2836942 , @sunfish wrote: > Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or > wasm32-wasi eventually? This is talking a step away from that. I definitely think we should unify them as much

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sunfish added a comment. Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or wasm32-wasi eventually? This is talking a step away from that. One of the assumptions behind this is that it would be ok for malloc to be 16-byte aligned anyway, because SIMD use cases benefit f

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

rsmith added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:954-956 +// Keeping the alignment of long double to 8 bytes even though its size is +// 16 bytes alows emscripten to have an 8-byte-aligned max_align_t which +// in turn gives is a 8-byte al

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. @sunfish what do you think about doing this for all WebAssembly targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104808/new/ https://reviews.llvm.org/D104808 ___ cfe-commits

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 created this revision. Herald added subscribers: wingo, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This means `max_align_t` is 8 bytes which also sets the alignment malloc. Since this is technically and