This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd1a96e906cc0: [clang][emscripten] Reduce alignof long double
from 16 to 8 bytes (authored by sbc100).
Changed prior to commit:
https://reviews.llvm.org/D104808?vs=354048&id=356223#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104808/new/
https://reviews.llvm.org/D104808
Files:
clang/lib/Basic/Targets/OSTargets.h
Index: clang/lib/Basic/Targets/OSTargets.h
===================================================================
--- clang/lib/Basic/Targets/OSTargets.h
+++ clang/lib/Basic/Targets/OSTargets.h
@@ -948,8 +948,16 @@
}
public:
- explicit EmscriptenTargetInfo(const llvm::Triple &Triple, const
TargetOptions &Opts)
- : WebAssemblyOSTargetInfo<Target>(Triple, Opts) {}
+ explicit EmscriptenTargetInfo(const llvm::Triple &Triple,
+ const TargetOptions &Opts)
+ : WebAssemblyOSTargetInfo<Target>(Triple, Opts) {
+ // Keeping the alignment of long double to 8 bytes even though its size is
+ // 16 bytes allows emscripten to have an 8-byte-aligned max_align_t which
+ // in turn gives is a 8-byte aligned malloc.
+ // Emscripten's ABI is unstable and we may change this back to 128 to match
+ // the WebAssembly default in the future.
+ this->LongDoubleAlign = 64;
+ }
};
} // namespace targets
Index: clang/lib/Basic/Targets/OSTargets.h
===================================================================
--- clang/lib/Basic/Targets/OSTargets.h
+++ clang/lib/Basic/Targets/OSTargets.h
@@ -948,8 +948,16 @@
}
public:
- explicit EmscriptenTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
- : WebAssemblyOSTargetInfo<Target>(Triple, Opts) {}
+ explicit EmscriptenTargetInfo(const llvm::Triple &Triple,
+ const TargetOptions &Opts)
+ : WebAssemblyOSTargetInfo<Target>(Triple, Opts) {
+ // Keeping the alignment of long double to 8 bytes even though its size is
+ // 16 bytes allows emscripten to have an 8-byte-aligned max_align_t which
+ // in turn gives is a 8-byte aligned malloc.
+ // Emscripten's ABI is unstable and we may change this back to 128 to match
+ // the WebAssembly default in the future.
+ this->LongDoubleAlign = 64;
+ }
};
} // namespace targets
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
