[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Whitney Tsang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab244db1fa0b: [AIX] Emitting diagnostics error for profile options (authored by Whitney). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://reviews.llvm.org/D104803 __

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Whitney Tsang via Phabricator via cfe-commits
Whitney updated this revision to Diff 354108. Whitney added a comment. move code later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://reviews.llvm.org/D104803 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/un

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:786 +<< PGOGenerateArg->getSpelling() << "-flto"; +if (ProfileGenerateArg) + D.Diag(diag::err_drv_unsupported_opt_for_target) Isn't this block of

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Whitney Tsang via Phabricator via cfe-commits
Whitney updated this revision to Diff 354096. Whitney marked an inline comment as done. Whitney added a comment. Updated one of the test cases to use `--target=powerpc64-ibm-aix`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://re

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/unsupported-option.c:14 + +// RUN: not %clang -fprofile-generate --target=powerpc-ibm-aix %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=AIX-PROFILE-LTO Worthwhile to use the 64-bit tri

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

2021-06-23 Thread Whitney Tsang via Phabricator via cfe-commits
Whitney created this revision. Whitney added reviewers: hubert.reinterpretcast, etiotto, bmahjour, kbarton, daltenty. Whitney added a project: LLVM. Whitney requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only LLVM-based instrumentation pr