hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:786 + << PGOGenerateArg->getSpelling() << "-flto"; + if (ProfileGenerateArg) + D.Diag(diag::err_drv_unsupported_opt_for_target) ---------------- Isn't this block of code a bit too early? The adjustment to consider the "no" form as equivalent to not having any `ProfileGenerateArg` is later in the function. I think it makes sense to move this to after the group of blocks that deal with more "fundamental" option conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://reviews.llvm.org/D104803 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
