[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24037c37b6c4: Add support for #pragma system_header with -fms-extensions (authored by hans). Changed prior to commit: https://reviews.llvm.org/D10

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added a comment. In D104770#2835596 , @aaron.ballman wrote: > LGTM, though you could add a test that `#pragma system_header` gives a > diagnostic outside of `-fms-extensions` mode if you think that's valuable. Thanks! Yes, I'll do that, and I'll a

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you could add a test that `#pragma system_header` gives a diagnostic outside of `-fms-extensions` mode if you think that's valuable. Repository: rG LLVM Github Mo

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added inline comments. Comment at: clang/test/Lexer/pragma-operators.cpp:22 #define pragma_L _Pragma(L"GCC diagnostic push") -#define pragma_u8 _Pragma(u8"system_header") +#define pragma_u8 _Pragma(u8"pack(1)") #define pragma_u _Pragma(u"GCC diagnostic pop") --

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans created this revision. hans added a reviewer: thakis. hans requested review of this revision. Herald added a project: clang. Clang already supports the pragma prefixed by "GCC" or "clang". MSVC has more recently added support for the pragma, but without any prefix; see https://devblogs.mic