[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGa08fa8a50819: [Clang-Format] Add ReferenceAlignment directive (authored by Seraphime Kirkovski , committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski marked 5 inline comments as done. skirkovski added a comment. Rebased and fixed warning. My local compiler was yelling at me for adding a default case to switch which already covers everything. For the commit: Author: Seraphime Kirkovski email: skirkovski at vmware.com Repository:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 352753. skirkovski added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay added a comment. This patch needs rebasing, please also make comments as "Done" once you have addressed them. Comment at: clang/lib/Format/TokenAnnotator.cpp:4162 +return FormatStyle::PAS_Middle; + } +} you are missing a return value here

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. In D104096#2820206 , @skirkovski wrote: > Ping, > > I do not have commit access, can someone submit this as time permits ? Please state the name and email for the commit, I will commit it on the weekend. Repository:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. Ping, I do not have commit access, can someone submit this as time permits ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cf

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-comm

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. @MyDeveloperDay, Thanks for the review. I do not have submit access. Can you take care of landing the revision when you have some free time ? Comment at: clang/unittests/Format/FormatTest.cpp:1243 + verifyFormat("int *f1(int &a) const & = 0;", Sty

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351649. skirkovski marked 3 inline comments as done. skirkovski added a comment. Sort ReferenceAlignment after RawStringFormats in mapping() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Format/Format.h:2647 - /// The ``&`` and ``*`` alignment style. + /// The ``&``, ``&&`` and ``*`` alignment style.

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 351645. skirkovski added a comment. Remove PAS_Pointer from Webkit style (since it derives from LLVM which already has it) Add empty lines between style change in the test case Split a verifyFormat with 3 different cases into different ones Add test cases

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. Can you also add tests with the alignment of declarations? We already have such for pointers. Comment at: clang/include/clang/Format/Format.h:2706 + /// references). + ReferenceAlignmentStyle ReferenceAlignment; + Please m

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay added a comment. A new nits but I'd say it was pretty good. Comment at: clang/lib/Format/Format.cpp:1356 Style.PointerAlignment = FormatStyle::PAS_Left; + Style.ReferenceAlignment = FormatStyle::RAS_Pointer; Style.SpaceBeforeCpp11BracedList = true; ---

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski created this revision. skirkovski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a roll-forward of D90238 originally implemented by @mrexodia and @catskul This introduces `ReferenceAli