skirkovski added a comment. @MyDeveloperDay,
Thanks for the review. I do not have submit access. Can you take care of landing the revision when you have some free time ? ================ Comment at: clang/unittests/Format/FormatTest.cpp:1243 + verifyFormat("int *f1(int &a) const & = 0;", Style); + verifyFormat("int *a = f1();\nint &b = f2();\nint &&c = f3();", Style); + Style.PointerAlignment = FormatStyle::PAS_Left; ---------------- HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > could you put each line on its own line. makes it easier to reason about > Please also add the empty line. Transformed each assignment to a separate verifyFormat. Is this what you meant ? Added test case for consecutive alignments which covers the previous verifyFormat with multiple assignemnts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits