This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0e8506debae3: [SystemZ][z/OS] Pass OpenFlags when creating
tmp files (authored by abhina.sreeskantharajan).
Repository:
rG LLVM Github Monorepo
C
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103806/new/
https://reviews.llvm.org/D103806
___
abhina.sreeskantharajan updated this revision to Diff 350386.
abhina.sreeskantharajan added a comment.
Address rnk's comments and rename to ExtraFlags
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103806/new/
https://reviews.llvm.org/D103806
Files
rnk added inline comments.
Comment at: llvm/lib/Support/Path.cpp:1295
SmallString<128> ResultPath;
- if (std::error_code EC =
- createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode))
+ if (std::error_code EC = createUniqueFile(Model, FD, ResultPath, Flags,
Mode)
abhina.sreeskantharajan added inline comments.
Comment at: llvm/lib/Support/Path.cpp:1295
SmallString<128> ResultPath;
- if (std::error_code EC =
- createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode))
+ if (std::error_code EC = createUniqueFile(Model, FD, Resul
rnk added a comment.
I see, thanks.
Comment at: llvm/lib/Support/Path.cpp:1295
SmallString<128> ResultPath;
- if (std::error_code EC =
- createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode))
+ if (std::error_code EC = createUniqueFile(Model, FD, ResultPath, Fl
abhina.sreeskantharajan created this revision.
Herald added subscribers: dexonsmith, hiraditya.
abhina.sreeskantharajan requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This patch https://reviews.llvm.org/D102876 caused som
