[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman closed this revision. aaron.ballman added a comment. In D102906#2777296 , @ivanmurashko wrote: > Hi @aaron.ballman > >> Thanks! Do you need someone to commit on your behalf? > > I will appreciate your assistance in the diff landing. Thank

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko marked an inline comment as done. ivanmurashko added a comment. Hi @aaron.ballman > Thanks! Do you need someone to commit on your behalf? I will appreciate your assistance in the landing the diff. > If so, what name and email address would you like used for patch attribution? It w

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman added a comment. Thanks! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko updated this revision to Diff 347326. ivanmurashko added a comment. @DmitryPolukhin suggestion was applied Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D102906 Files: clang-tools-extra/clang-tid

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the nit from @DmitryPolukhin Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72 +Error = DiagnosticsEngine::Error, +Remark = D

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

DmitryPolukhin added inline comments. Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72 +Error = DiagnosticsEngine::Error, +Remark = DiagnosticsEngine::Remark }; nit, I would move remark first to have list by increasing severity. It looks l

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko created this revision. ivanmurashko added reviewers: aaron.ballman, alexfh, DmitryPolukhin, gribozavr2. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. ivanmurashko requested review of this revision. Herald added a subscriber: cfe-commits.