aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from the nit from @DmitryPolukhin ================ Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72 + Error = DiagnosticsEngine::Error, + Remark = DiagnosticsEngine::Remark }; ---------------- DmitryPolukhin wrote: > nit, I would move remark first to have list by increasing severity. It looks > like this enum values is not used outside of the sources so I hope it is safe. We have diagnostic notes as well and it's not clear to me how to order remark and note should we go that way in the future. So I'm not opposed to the suggestion, but the order likely doesn't matter all that much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D102906 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
