[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdccf5c7dfb9e: [M68k] Support for inline asm operands w/ simple constraints (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added a comment. In D102585#2769887 , @nickdesaulniers wrote: > Looking good @myhsu . Also, I got your LLVM book recently! You'll need to > sign it for me at the next llvm conf in person. Thank you :-) Hope you will like it. I'll start to pract

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346638. myhsu marked 4 inline comments as done. myhsu added a comment. - Add test cases for valid constraints - Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files: clang/lib/Basic/Targets

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. Looking good @myhsu . Also, I got your LLVM book recently! You'll need to sign it for me at the next llvm conf in person. Comment at: clang/lib/Basic/Targets/M68k.cpp:197-199 +std::string R = std::string("^") + std::string(Constraint, 2);

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); nickdesaulniers wrote: > did you mean to drop support for `'f'`? To drop it for now.

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346338. myhsu marked 2 inline comments as done. myhsu added a comment. Fixed lint warning and added more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files: clang/lib/Basic/Targets/M68k.cpp

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. LGTM but please review the linter warnings. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); did you mean to drop support for `

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu created this revision. myhsu added reviewers: echristo, craig.topper. Herald added a subscriber: hiraditya. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds supports for inline assembly operands