nickdesaulniers added a comment.
LGTM but please review the linter warnings.
================
Comment at: clang/lib/Basic/Targets/M68k.cpp:145
case 'd': // data register
- case 'f': // floating point register
info.setAllowsRegister();
----------------
did you mean to drop support for `'f'`?
================
Comment at: llvm/test/CodeGen/M68k/inline-asm.ll:36
+ call void asm sideeffect "move.l $0, %d1", "^Cj"(i32 -32769)
+ call void asm sideeffect "move.l $0, %d1", "^Cj"(i32 32768)
+ ret void
----------------
You probably should add tests for all newly added constraints with valid input.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102585/new/
https://reviews.llvm.org/D102585
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
