[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. Herald added subscribers: Enna1, abrachet, MaskRay. Herald added a project: All. Partially merged (making -fsanitize=scudo use scudo_standalone) merged in D138157 . Will probably re-use this in a bit to add the dangling scudo tests to scud

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. sanitizer-x86_64-linux https://lab.llvm.org/buildbot/#/builders/37/builds/4244 FAIL: ScudoStandalone-x86_64 :: preinit.c (772 of 856) ppc64be-clang-test https://lab.llvm.org/buildbot#builders/52/builds/7794 TEST 'ScudoStandalone-powerpc64 :: preinit.c' FAILED among othe

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. In D102543#2783516 , @cryptoad wrote: > I saw some bots failure for preinit.c: > > FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) > TEST 'ScudoStandalone-i386 :: preinit.c' FAILED > **

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I saw some bots failure for preinit.c: FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) TEST 'ScudoStandalone-i386 :: preinit.c' FAILED Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux/build/clang_bui

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 348116. hctim added a comment. Move lit tests behind the cmake guard: "if(COMPILER_RT_INCLUDE_TESTS AND COMPILER_RT_HAS_SCUDO_STANDALONE)" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://review

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG694d8cbe: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests. (authored by hctim). Changed prior to commit: https://reviews.llvm.org/D102543?vs=347814&id=348011#toc Repository: rG LLVM G

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 347814. hctim marked an inline comment as done. hctim added a comment. Address Vitaly's suggestions, make some slight changes so that cross-compilation and running under QEMU doesn't require staging the runtimes in the host compiler. Repository: rG LLVM Gi

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC +

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC + SCUDO_STANDALONE_TEST_TAR

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345977. hctim added a comment. Let's submit the "adding archs" part of the patch first, then land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/l

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345975. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) -set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) +set(ALL_SCUDO_STANDALONE_SUPPOR

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345967. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added a comment. Would you mind to clang-format entire existing compiler-rt/test/scudo/ and than rebase this patch on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 __

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345939. hctim added a comment. Add arm32 to supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad accepted this revision. cryptoad added a comment. This revision is now accepted and ready to land. I think this is good, with the additional arch Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345906. hctim marked 2 inline comments as done. hctim added a comment. Address Kostya's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Dri

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added a comment. In D102543#2763749 , @cryptoad wrote: > I think one of the remaining things to address is the supported architectures: > > set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${M

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I think one of the remaining things to address is the supported architectures: set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) I am unclear as to whethe

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. Thanks a lot Mitch! Couple of comments from a first look, I'll give it another go later. Comment at: compiler-rt/lib/scudo/standalone/wrappers_cpp.cpp:42 + if (Allocator.canReturnNull()) { \ +errno

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim created this revision. hctim added reviewers: cryptoad, pcc. Herald added subscribers: phosek, mgorny. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch moves -fsanitize=scudo to link the standalon