[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2766240 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/9739/step_7.txt > http://45.33.8.238/mac/31615/step_7.txt > > Please take a look, and please revert for now if it takes

[PATCH] D102261: Introduce SYCL 2020 mode

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/9739/step_7.txt http://45.33.8.238/mac/31615/step_7.txt Please take a look, and please revert for now if it takes a while to fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://re

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in 6381664580080f015bc0c2ec647853f697cf744a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://rev

[PATCH] D102261: Introduce SYCL 2020 mode

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Sorry for the delay. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commit

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2754289 , @tschuett wrote: > My bad. My last comment: > > LangOptions::SYCL::Ver2017 > LangOptions::SYCL_2017 To me, those convey the same amount of information, so the use of the scoped enum doesn't get us

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. My bad. My last comment: LangOptions::SYCL::Ver2017 LangOptions::SYCL_2017 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751832 , @tschuett wrote: > The Ver in Ver2020 is redundant ::2020 would suffice. That is not valid syntax. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. The Ver in Ver2020 is redundant ::2020 would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751819 , @tschuett wrote: > But there is no SYCLMinorVersion today. So enum class SYCLVersion would > suffice. I don't think the presence of the word 'Major' in Aaron's suggestion is the most offensive to me. Wh

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. But there is no SYCLMinorVersion today. So enum class SYCLVersion would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2751782 , @tschuett wrote: > No worries. I just wondered why only ClangABI is scoped ^^ :-) FWIW, I think it's because `LangOptions::Ver1` would be hard to understand compared to `LangOptions::ClangABI::Ver1`,

[PATCH] D102261: Introduce SYCL 2020 mode

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, aaron.ballman wrote: > tschuett wrote: > > Do you want to change it to a scoped enum or will this cause major issues? > > Clan

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. No worries. I just wondered why only ClangABI is scoped ^^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, tschuett wrote: > Do you want to change it to a scoped enum or will this cause major issues? > ClangABI is a scoped enum?!?

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, Do you want to change it to a scoped enum or will this cause major issues? ClangABI is a scoped enum?!? CHANGES SINCE LAST ACT

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman updated this revision to Diff 344496. aaron.ballman added a comment. Remove some accidental additional changes for SYCL 2017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 Files: clang/include/clang/Basic/LangOptions.def cl

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:481 Builder.defineMacro("CL_SYCL_LANGUAGE_VERSION", "121"); + Builder.defineMacro("SYCL_LANGUAGE_VERSION", "201707"); +} else if (LangOpts.getSYCLVersion() == LangOptions::SYC

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. LGTM, but want others to look first. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:481 Builder.defineMacro("CL_SYCL_LANGUAGE_VERSION", "121"); + Builder.defineMacro("SYCL_LANGUAGE_VERSION", "201707"); +} else if (LangOpts.getSYC

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman created this revision. aaron.ballman added reviewers: bader, erichkeane, jansvoboda11. Herald added subscribers: Naghasan, dexonsmith, dang, Anastasia, ebevhan, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, we have support for SYC