[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 abandoned this revision. pooja2299 added a comment. Closing this issue because the default workgroup size is 1024 now, so no changes are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247 +and is an optimization hint. It is mandatory to use this attribute in some +situations. Because when the attribute is absent, the compiler assumes the +default maximum workgroup size o

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

xgupta resigned from this revision. xgupta added a comment. I am really an idol reviewer for this patch -:) don't know anything about AMDGPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 _

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

arsenm added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247 +and is an optimization hint. It is mandatory to use this attribute in some +situations. Because when the attribute is absent, the compiler assumes the +default maximum workgroup size of 2

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

aaron.ballman added a comment. In D102134#2751184 , @pooja2299 wrote: > In D102134#2747649 , @aaron.ballman > wrote: > >> Minor wordsmithing on the documentation changes, but more importantly: why >> is the corr

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 added a comment. In D102134#2747649 , @aaron.ballman wrote: > Minor wordsmithing on the documentation changes, but more importantly: why is > the correct fix to the documentation as opposed to changing the default max > working group size? H

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Minor wordsmithing on the documentation changes, but more importantly: why is the correct fix to the documentation as opposed to changing the default max working group

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 updated this revision to Diff 343920. pooja2299 added a comment. Made some corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 Files: clang/include/clang/Basic/AttrDocs.td Index: cla

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 updated this revision to Diff 343919. pooja2299 added a comment. Amended the flat_work_group_size section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 Files: clang/include/clang/Basic/Attr

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 created this revision. pooja2299 added a reviewer: xgupta. Herald added a subscriber: tpr. Herald added a reviewer: aaron.ballman. pooja2299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed the documentation of amdgpu_flat_