pooja2299 updated this revision to Diff 343919.
pooja2299 added a comment.

Amended the flat_work_group_size section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102134/new/

https://reviews.llvm.org/D102134

Files:
  clang/include/clang/Basic/AttrDocs.td


Index: clang/include/clang/Basic/AttrDocs.td
===================================================================
--- clang/include/clang/Basic/AttrDocs.td
+++ clang/include/clang/Basic/AttrDocs.td
@@ -2241,7 +2241,10 @@
 Clang supports the
 ``__attribute__((amdgpu_flat_work_group_size(<min>, <max>)))`` attribute for 
the
 AMDGPU target. This attribute may be attached to a kernel function definition
-and is an optimization hint.
+and is an optimization hint. It is mandatory to use this attribute in some 
+situations. Because when the attribute is absent, the compiler assumes the 
+default maximum workgroup size of 256 but currently the workgroup size can 
legally go 
+to 1024. 
 
 ``<min>`` parameter specifies the minimum flat work-group size, and ``<max>``
 parameter specifies the maximum flat work-group size (must be greater than


Index: clang/include/clang/Basic/AttrDocs.td
===================================================================
--- clang/include/clang/Basic/AttrDocs.td
+++ clang/include/clang/Basic/AttrDocs.td
@@ -2241,7 +2241,10 @@
 Clang supports the
 ``__attribute__((amdgpu_flat_work_group_size(<min>, <max>)))`` attribute for the
 AMDGPU target. This attribute may be attached to a kernel function definition
-and is an optimization hint.
+and is an optimization hint. It is mandatory to use this attribute in some 
+situations. Because when the attribute is absent, the compiler assumes the 
+default maximum workgroup size of 256 but currently the workgroup size can legally go 
+to 1024. 
 
 ``<min>`` parameter specifies the minimum flat work-group size, and ``<max>``
 parameter specifies the maximum flat work-group size (must be greater than
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to