[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D101952#2742237 , @DavidSpickett wrote: > Thanks! I'll test our Arm build and revert the requires once I've confirmed > it passes. This is not the fix you need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-06 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Thanks! I'll test our Arm build and revert the requires once I've confirmed it passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 _

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-05 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b843d8819: [OpenMP] Fix non-determinism in clang copyin codegen (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ ht

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-05 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 343262. ggeorgakoudis added a comment. Update for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-05 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, two nits, one below. Add a sentence to the commit message describing the problem. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1013 + Builder.Crea

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-05 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 343256. ggeorgakoudis added a comment. Update by Johanne's correction on the source of non-determinism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files:

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

2021-05-05 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https