jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land.
LGTM, two nits, one below. Add a sentence to the commit message describing the problem. ================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1013 + Builder.CreatePtrToInt(PrivateAddr.getPointer(), CGM.IntPtrTy); + Builder.CreateCondBr(Builder.CreateICmpNE(A, B), CopyBegin, CopyEnd); EmitBlock(CopyBegin); ---------------- Rename A to MasterAddrInt and B to PrivateAddrInt, or similar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits