[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

This revision was automatically updated to reflect the committed changes. Closed by commit rGb14a6f06cc87: [ARM][MVE] vcreateq lane ordering for big endian (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://re

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson marked 2 inline comments as done. tmatheson added a comment. In D101606#2728320 , @dmgreen wrote: > Sounds good to me. > > Whilst we are here, are any of the other uses of bitcast in arm_mve.td > potentially a problem? I took a quick look and b

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the updates. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341823. tmatheson added a comment. Use --check-prefixes=CHECK,CHECK-BE etc to combine common blocks. Sorry for the churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D10

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341819. tmatheson added a comment. remove old check lines that were not automatically removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606 Files: clang/include

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:86 // CHECK-LABEL: @test_vcreateq_s64( // CHECK-NEXT: entry: You have to remove the old checks - the script isn't very good at that. What would probably be even better

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341818. tmatheson edited the summary of this revision. tmatheson added a comment. Use update_cc_test_checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606 Files:

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // MarkMurrayARM wrote: > dmgreen wr

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

MarkMurrayARM added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // dmgreen wrote: > MarkMurrayAR

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen added a comment. Sounds good to me. Whilst we are here, are any of the other uses of bitcast in arm_mve.td potentially a problem? I took a quick look and because they both converting the inputs and the outputs, I believe they will be OK. (Two wrongs make a right, if you will). =