tmatheson marked 2 inline comments as done.
tmatheson added a comment.

In D101606#2728320 <https://reviews.llvm.org/D101606#2728320>, @dmgreen wrote:

> Sounds good to me.
>
> Whilst we are here, are any of the other uses of bitcast in arm_mve.td 
> potentially a problem? I took a quick look and because they both converting 
> the inputs and the outputs, I believe they will be OK. (Two wrongs make a 
> right, if you will).

I had a look and came to the same conclusion, I couldn't find any way to make 
them break. Worth noting that they are all converting between vectors with the 
same number of lanes, e.g. typically between the signed and unsigned versions 
of NxM vectors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101606/new/

https://reviews.llvm.org/D101606

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to