[PATCH] D101457: [clang] remove dead code after 2a1332245fc

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. > The real question is how did you find this? :) No exciting answer, I'm afraid: I just happened to read this code while looking at something else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/ https://reviews.

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d493291bd01: [clang] remove dead code after 2a1332245fc (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

2021-04-28 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm The real question is how did you find this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/ https://reviews.llvm.org/D101457 __

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

2021-04-28 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. Herald added a reviewer: aaron.ballman. thakis requested review of this revision. Commit 2a1332245fc extracted this code to a new function checkSectionName() and added a call to it, but didn't remove the original code. The original code