thakis created this revision.
thakis added a reviewer: hans.
Herald added a reviewer: aaron.ballman.
thakis requested review of this revision.
Commit 2a1332245fc extracted this code to a new function checkSectionName() and
added a call to it, but didn't remove the original code. The original code
is dead since the checkSectionName() early return would fire when it would
trigger. (If it weren't dead, it'd make clang crash since
err_attribute_section_invalid_for_target now takes two args instead of just the
one that's passed.)
No behavior change.
https://reviews.llvm.org/D101457
Files:
clang/lib/Sema/SemaDeclAttr.cpp
Index: clang/lib/Sema/SemaDeclAttr.cpp
===================================================================
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -3006,13 +3006,6 @@
if (!S.checkSectionName(LiteralLoc, Str))
return;
- // If the target wants to validate the section specifier, make it happen.
- if (llvm::Error E = S.Context.getTargetInfo().isValidSectionSpecifier(Str)) {
- S.Diag(LiteralLoc, diag::err_attribute_section_invalid_for_target)
- << toString(std::move(E));
- return;
- }
-
SectionAttr *NewAttr = S.mergeSectionAttr(D, AL, Str);
if (NewAttr) {
D->addAttr(NewAttr);
Index: clang/lib/Sema/SemaDeclAttr.cpp
===================================================================
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -3006,13 +3006,6 @@
if (!S.checkSectionName(LiteralLoc, Str))
return;
- // If the target wants to validate the section specifier, make it happen.
- if (llvm::Error E = S.Context.getTargetInfo().isValidSectionSpecifier(Str)) {
- S.Diag(LiteralLoc, diag::err_attribute_section_invalid_for_target)
- << toString(std::move(E));
- return;
- }
-
SectionAttr *NewAttr = S.mergeSectionAttr(D, AL, Str);
if (NewAttr) {
D->addAttr(NewAttr);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
