[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 ___ cfe-

[PATCH] D100514: [OpenMP] Added codegen for masked directive

jdoerfert added a comment. In D100514#2696106 , @cchen wrote: >> Initially we did not have an OMPIRBuilder object unconditionally, now we >> have. Let's move over everything that is ready. So master and critical >> should be good to go as well I suppose

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. > Initially we did not have an OMPIRBuilder object unconditionally, now we > have. Let's move over everything that is ready. So master and critical should > be good to go as well I suppose. While using OMPIRBuilder as default, do we want to just remove codegen in Clang o

[PATCH] D100514: [OpenMP] Added codegen for masked directive

jdoerfert added a comment. In D100514#2695271 , @cchen wrote: > In D100514#2693600 , @jdoerfert > wrote: > >> Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, >> many thanks for providin

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693601 , @jdoerfert wrote: > Also, don't forget to mark it as done in > https://clang.llvm.org/docs/OpenMPSupport.html :) I'll mark it as done after combined constructs are also done. Thanks! Repository: rG LLVM Gi

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693600 , @jdoerfert wrote: > Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, > many thanks for providing one!) > We have an OMPIRBuilder always around in clang's codegen, so there is little >

[PATCH] D100514: [OpenMP] Added codegen for masked directive

jdoerfert added a comment. Also, don't forget to mark it as done in https://clang.llvm.org/docs/OpenMPSupport.html :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 _

[PATCH] D100514: [OpenMP] Added codegen for masked directive

jdoerfert added a comment. Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, many thanks for providing one!) We have an OMPIRBuilder always around in clang's codegen, so there is little reason not to use it if it is feature complete. Repository: rG LLVM Github Monorep

[PATCH] D100514: [OpenMP] Added codegen for masked directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c2125d1d1e: [OpenMP] Added codegen for masked directive (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D100514: [OpenMP] Added codegen for masked directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 ___

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen updated this revision to Diff 337797. cchen added a comment. Update test and fix code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/li

[PATCH] D100514: [OpenMP] Added codegen for masked directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3853-3855 + if (const auto *FilterClause = S.getSingleClause()) { +Filter = FilterClause->getThreadID(); + } No need for braces here Comment at: clang/test/Open

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repos